Conversation
This comment was marked as low quality.
This comment was marked as low quality.
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to issue #800
monero-walletcrate tomonero_walletbecause apparently there's a name conflict which prevents the tests from running with default parameters.integration_testmacro. inline async closures can keep captured wallet resources alive past the test body, which can race with harness teardown and trigger a segfault during c++ wallet destruction. the macro moves test logic into a separate async function passed tosetup_testwhich gives wallet resources a clearer drop boundary before teardown.test results (i3-4160):
